tim/xxx
1
0
Fork 0
Code Issues Pull Requests Releases Activity

Match usernames and session keys with = instead of LIKE.

Browse Source 
A username of "%" matched the first editor.
This commit is contained in:
tim
2026-09-25 21:39:25 +02:00
parent 36c7fe97c5
commit 15ad07423a
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
publish/login.php
+1 -1
View File
@@ -17,7 +17,7 @@ if (isset($_SESSION['editor'])) {
open_db('open'); open_db('open');
$username = (string)($_POST['username'] ?? ''); $username = (string)($_POST['username'] ?? '');
$query = "SELECT * FROM $table WHERE username LIKE ? LIMIT 1"; $query = "SELECT * FROM $table WHERE username = ? LIMIT 1";
$getid = $db->execute_query($query, array($username)) or die("Query failed: ".$db->error); $getid = $db->execute_query($query, array($username)) or die("Query failed: ".$db->error);
$row = $getid->fetch_assoc(); $row = $getid->fetch_assoc();
session.lib.php
+2 -2
View File
@@ -36,7 +36,7 @@ function check_persistent_login() {
$cookie_data = (string)$_COOKIE['PersistentAuth']; $cookie_data = (string)$_COOKIE['PersistentAuth'];
list($username, $key) = explode("|", $cookie_data, 2) + array('', ''); list($username, $key) = explode("|", $cookie_data, 2) + array('', '');
$query = "SELECT * FROM $table WHERE username LIKE ? LIMIT 1"; $query = "SELECT * FROM $table WHERE username = ? LIMIT 1";
$getid = $db->execute_query($query, array($username)) or die("Query failed: ".$db->error); $getid = $db->execute_query($query, array($username)) or die("Query failed: ".$db->error);
$row = $getid->fetch_assoc(); $row = $getid->fetch_assoc();
open_db('close'); open_db('close');
@@ -86,7 +86,7 @@ function delete_persistent_login() {
list($username, $key) = explode("|", $cookie_data, 2) + array('', ''); list($username, $key) = explode("|", $cookie_data, 2) + array('', '');
// Remove this session key from the database // Remove this session key from the database
$query = "DELETE FROM $table WHERE username LIKE ? AND session LIKE ?"; $query = "DELETE FROM $table WHERE username = ? AND session = ?";
$db->execute_query($query, array($username, $key)) or die("Query failed: ".$db->error); $db->execute_query($query, array($username, $key)) or die("Query failed: ".$db->error);
// Reap old sessions // Reap old sessions