Rename bms_temperature_celcius to bms_temperature_celsius
Correct the spelling in the JBD and EcoFlow snapshots, the diagnostic tool, and the tests. UPS.from_dict maps the old name to the new name, so a client still reads data from an older server during an upgrade. InfluxDB and Prometheus now receive this measurement under the new name.
This commit is contained in:
@@ -153,13 +153,13 @@ class TestJBDBMS:
|
||||
assert "bms_voltage_total_volts" in keys
|
||||
assert "bms_current_amps" in keys
|
||||
assert "bms_manufacture_date" in keys
|
||||
assert "bms_temperature_celcius" in keys
|
||||
assert "bms_temperature_celsius" in keys
|
||||
|
||||
def test_items_yields_correct_types(self, populated_jbdbms):
|
||||
d = dict(populated_jbdbms.items())
|
||||
assert isinstance(d["bms_voltage_total_volts"], BMSScalarField)
|
||||
assert isinstance(d["bms_manufacture_date"], BMSInfoField)
|
||||
assert isinstance(d["bms_temperature_celcius"], BMSMultiField)
|
||||
assert isinstance(d["bms_temperature_celsius"], BMSMultiField)
|
||||
|
||||
def test_is_ups_subclass(self):
|
||||
assert isinstance(JBDBMS(), UPS)
|
||||
@@ -209,8 +209,8 @@ class TestParse03Response:
|
||||
|
||||
def test_temperature(self, valid_03_response):
|
||||
result = parse_03_response(valid_03_response)
|
||||
assert result.bms_temperature_celcius.raw_values[1] == pytest.approx(25.0)
|
||||
assert result.bms_temperature_celcius.units == "°C"
|
||||
assert result.bms_temperature_celsius.raw_values[1] == pytest.approx(25.0)
|
||||
assert result.bms_temperature_celsius.units == "°C"
|
||||
|
||||
def test_mosfet_charging(self, valid_03_response):
|
||||
result = parse_03_response(valid_03_response)
|
||||
@@ -379,9 +379,9 @@ class TestParse03ProtectionBits:
|
||||
_recompute_checksum(response)
|
||||
result = parse_03_response(response)
|
||||
assert isinstance(result, JBDBMS)
|
||||
assert len(result.bms_temperature_celcius.raw_values) == 2
|
||||
assert result.bms_temperature_celcius.raw_values[1] == pytest.approx(25.0)
|
||||
assert result.bms_temperature_celcius.raw_values[2] == pytest.approx(19.2)
|
||||
assert len(result.bms_temperature_celsius.raw_values) == 2
|
||||
assert result.bms_temperature_celsius.raw_values[1] == pytest.approx(25.0)
|
||||
assert result.bms_temperature_celsius.raw_values[2] == pytest.approx(19.2)
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
Reference in New Issue
Block a user