tim/bmspy
1
0
Fork 0
Code Issues Pull Requests Releases Activity

Handle a JBD read that returns no response

Browse Source 
collect_data called len() on each response. A port that cannot open returns False or None, so the call raised TypeError and ended the server. Treat each empty or absent response as a failed read.
This commit is contained in:
tim
2026-10-10 09:03:33 +02:00
parent aa9888800e
commit c97f6cc176
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bmspy/jbd_bms.py
+3 -2
View File
@@ -116,7 +116,8 @@ def collect_data(ser: serial.Serial, debug: int = 0) -> JBDBMS | bool:
reqmsg = bytearray([0xDD, 0xA5, 0x03, 0x00, 0xFF, 0xFD, 0x77]) reqmsg = bytearray([0xDD, 0xA5, 0x03, 0x00, 0xFF, 0xFD, 0x77])
response_03 = requestMessage(ser, reqmsg, debug) response_03 = requestMessage(ser, reqmsg, debug)
if len(response_03) == 0: # A port that cannot open returns False or None, not an empty response.
if not response_03:
if debug > 0: if debug > 0:
debugger("collect_data: Error retrieving BMS info. Trying again...") debugger("collect_data: Error retrieving BMS info. Trying again...")
return False return False
@@ -125,7 +126,7 @@ def collect_data(ser: serial.Serial, debug: int = 0) -> JBDBMS | bool:
reqmsg = bytearray([0xDD, 0xA5, 0x04, 0x00, 0xFF, 0xFC, 0x77]) reqmsg = bytearray([0xDD, 0xA5, 0x04, 0x00, 0xFF, 0xFC, 0x77])
response_04 = requestMessage(ser, reqmsg, debug) response_04 = requestMessage(ser, reqmsg, debug)
if len(response_04) == 0: if not response_04:
if debug > 0: if debug > 0:
debugger("collect_data: Error retrieving BMS info. Trying again...") debugger("collect_data: Error retrieving BMS info. Trying again...")
return False return False