Move and delete chapters by hand in the chapter list

The merge cannot always tell where new chapters go. For example, a site
can list an announcement before the chapters of an old book. You can now
select chapters and move them, in their order, to after another chapter
or to the start. You can also delete them with their revisions. A story
keeps at least one chapter. The book is then rebuilt. A deleted chapter
that the site still lists comes back with the next download.

The Move… and Delete… buttons open a dialog that names the selected
chapters before anything changes. A shift-click selects a range of
chapters.

The Select all checkbox moves into the first heading of the chapter
list. On a phone, that heading shows with the text "Select all".

tests/js/flow-helpers.mjs

@@ -30,6 +30,8 @@ export class Element {
   removeAttribute(name) { delete this.attributes[name]; }
   addEventListener(name, fn) { this.listeners[name] = fn; }
   focus() { document.activeElement = this; }
+  showModal() { this.open = true; }
+  close() { this.open = false; }
   remove() { if (this.parent) this.parent.children = this.parent.children.filter((child) => child !== this); }
   get firstElementChild() { return this.children.find((child) => child instanceof Element); }
   get textContent() { return this.children.map((child) => child instanceof Element ? child.textContent : String(child)).join(''); }

tests/js/flows.test.mjs

@@ -275,13 +275,13 @@ test('the chapter table stacks on a narrow screen instead of scrolling sideways'
   await mountStory();
   const wrap = nodes(main).find((el) => el.className === 'table-wrap chapters-table');
   assert.ok(wrap);
-  const headings = nodes(wrap).filter((el) => el.tagName === 'th').map((el) => el.textContent);
-  assert.deepEqual(headings, ['', '#', 'Title', 'State', 'Revisions', 'Added']);
+  const headings = nodes(wrap).filter((el) => el.tagName === 'th');
+  assert.deepEqual(headings.map((el) => el.textContent.trim()), ['Select all', '#', 'Title', 'State', 'Revisions', 'Added']);
   const dataLabels = nodes(wrap).filter((el) => el.tagName === 'td').map((el) => el.attributes['data-label']);
   const perRow = [undefined, '#', undefined, 'State', 'Revisions', 'Added'];
   assert.deepEqual(dataLabels, [...perRow, ...perRow]);
-  // "Select all" moved above the table, so a hidden table header on mobile does not hide it.
-  assert.ok(nodes(main).find((el) => el.tagName === 'label' && el.textContent.trim() === 'Select all'));
+  // The Select all checkbox is in the first heading. On a phone, it is the only heading that shows.
+  assert.ok(nodes(headings[0]).includes(field(main, 'Select all chapters')));
 });
 
 test('story list stacks on a narrow screen instead of scrolling sideways', async () => {
@@ -348,6 +348,47 @@ test('chapter inclusion changes reload the story after queuing the rebuild', asy
   assert.equal(api.sent('GET', 'stories/1').length, 3);
 });
 
+test('shift-click selects a range of chapters, and Move sends them with the chapter to go after', async () => {
+  details.chapters.push({ id: 4, title: 'Three', url: 'chapter-3', included: true, on_site: true, current_rev: 1, revisions: 1 });
+  await mountStory();
+  api.on('POST', 'stories/1/chapters/move', {});
+  const dialog = nodes(main).find((el) => el.tagName === 'dialog');
+  const texts = (tag) => nodes(dialog).filter((el) => el.tagName === tag).map((el) => el.textContent);
+  await click(main, 'Move…');
+  assert.ok(!dialog.open);
+  const box = (title) => field(main, `Select ${title}`);
+  const shiftClick = (el, on) => {
+    el.listeners.click({ shiftKey: true, target: el });
+    return change(el, on);
+  };
+  change(box('One'), true);
+  shiftClick(box('Three'), true);
+  assert.equal(box('Two').checked, true);
+  // The dialog names the chapters, and they are not in the list of chapters to go after.
+  await click(main, 'Move…');
+  assert.ok(dialog.open);
+  assert.deepEqual(texts('h3'), ['Move 3 chapters']);
+  assert.deepEqual(texts('li'), ['One', 'Two', 'Three']);
+  assert.deepEqual(texts('option'), ['The start']);
+  await click(dialog, 'Cancel');
+  assert.ok(!dialog.open);
+  assert.equal(writes().length, 0);
+  await click(main, 'Move…');
+  await click(dialog, 'Move');
+  assert.deepEqual(api.sent('POST', 'stories/1/chapters/move').at(-1).body, { chapter_ids: [2, 3, 4], after: null });
+  assert.ok(!dialog.open);
+  shiftClick(box('One'), false);
+  change(box('Two'), true);
+  await click(main, 'Move…');
+  assert.deepEqual(texts('option'), ['The start', 'One', 'Three']);
+  field(dialog, 'move-after').value = '4';
+  await click(dialog, 'Move');
+  assert.deepEqual(api.sent('POST', 'stories/1/chapters/move').at(-1).body, { chapter_ids: [3], after: 4 });
+  // The next dialog starts with the last choice.
+  await click(main, 'Move…');
+  assert.equal(field(dialog, 'move-after').value, '4');
+});
+
 test('unsaved metadata and update settings survive job completion, then save typed values', async () => {
   await mountStory();
   startPolling();
@@ -449,6 +490,30 @@ test('library search trims the query and links by UUID', async () => {
   assert.equal(api.sent('GET', 'stories/1').length, 2);
 });
 
+test('deleting chapters asks in a dialog and warns about chapters that are on the site', async () => {
+  await mountStory();
+  api.on('POST', 'stories/1/chapters/delete', {});
+  const dialog = nodes(main).find((el) => el.tagName === 'dialog');
+  const text = (tag) => nodes(dialog).find((el) => el.tagName === tag).textContent;
+  await click(main, 'Delete…');
+  assert.ok(!dialog.open);
+  change(field(main, 'Select Two'), true);
+  await click(main, 'Delete…');
+  assert.ok(dialog.open);
+  assert.equal(text('h3'), 'Delete 1 chapter');
+  assert.equal(text('p'), 'Bindery deletes this chapter and its revisions. You cannot undo this.');
+  await click(dialog, 'Cancel');
+  change(field(main, 'Select One'), true);
+  await click(main, 'Delete…');
+  assert.equal(text('h3'), 'Delete 2 chapters');
+  assert.match(text('p'), /^Bindery deletes these chapters and their revisions\..*comes back with the next download/);
+  assert.equal(writes().length, 0);
+  await click(dialog, 'Delete');
+  assert.deepEqual(api.sent('POST', 'stories/1/chapters/delete').at(-1).body, { chapter_ids: [2, 3] });
+  assert.ok(!dialog.open);
+  assert.equal(api.sent('GET', 'stories/1').length, 2);
+});
+
 test('sending as a new book and stopping tracking require confirmation', async () => {
   details.story.ingested_at = '2026-01-01';
   await mountStory();

tests/test_api_flows.py

@@ -64,6 +64,14 @@ def test_settings_and_inclusion_persist_and_delete_cascades(client, story):
     )
     assert response.json["mode"] == "rebuild"
     assert not o.store.get_chapter(cid)["included"]
+    response = client.post(f"/api/stories/{sid}/chapters/move", json={"chapter_ids": [cid], "after": None}, headers=H)
+    assert response.json["mode"] == "rebuild"
+    move = client.post(f"/api/stories/{sid}/chapters/move", json={"chapter_ids": [cid], "after": 999}, headers=H)
+    assert move.status_code == 404
+    # The story has only this chapter, so it cannot go.
+    response = client.post(f"/api/stories/{sid}/chapters/delete", json={"chapter_ids": [cid]}, headers=H)
+    assert response.status_code == 400
+    assert "at least one chapter" in response.json["error"]
     o.store.set_rules(sid, [{"pattern": "a", "replacement": "b", "enabled": True}])
     response = client.delete(f"/api/stories/{sid}", headers=H)
     assert response.json == {"deleted": sid}

tests/test_worker_flows.py

@@ -250,6 +250,47 @@ def test_inclusion_changes_only_the_requested_story_and_queues_a_rebuild(state):
     assert len(queue.get_status()) == 1
 
 
+def test_move_chapters_keeps_their_order_and_queues_a_rebuild(state):
+    store, queue = state
+    sid, other = add_story(store), add_story(store, "other")
+    ids = [store.add_chapter(sid, f"c{n}", str(n), "<p>x</p>", "h", "new", n) for n in range(5)]
+    foreign = store.add_chapter(other, "foreign", "Other", "<p>x</p>", "h", "new", 0)
+
+    def titles():
+        return [c["title"] for c in store.list_chapters(sid)]
+
+    # The selection order does not count, and a chapter of another story is ignored.
+    assert o.move_chapters(sid, [ids[3], ids[1], foreign], ids[4])["mode"] == "rebuild"
+    assert titles() == ["0", "2", "4", "1", "3"]
+    o.move_chapters(sid, [ids[4], ids[3]], None)
+    assert titles() == ["4", "3", "0", "2", "1"]
+    assert len(queue.get_status()) == 1
+    with pytest.raises(ValueError, match="Select"):
+        o.move_chapters(sid, [foreign], None)
+    with pytest.raises(ValueError, match="moves with them"):
+        o.move_chapters(sid, [ids[0], ids[1]], ids[1])
+    with pytest.raises(KeyError):
+        o.move_chapters(sid, [ids[0]], foreign)
+
+
+def test_delete_chapters_removes_their_revisions_and_keeps_one_chapter(state):
+    store, queue = state
+    sid, other = add_story(store), add_story(store, "other")
+    ids = [store.add_chapter(sid, f"c{n}", str(n), "<p>x</p>", "h", "new", n) for n in range(3)]
+    store.add_revision(ids[1], "<p>y</p>", "h2", "recheck")
+    foreign = store.add_chapter(other, "foreign", "Other", "<p>x</p>", "h", "new", 0)
+
+    assert o.delete_chapters(sid, [ids[1], foreign])["mode"] == "rebuild"
+    assert [c["id"] for c in store.list_chapters(sid)] == [ids[0], ids[2]]
+    assert store.list_revisions(ids[1]) == []
+    assert store.get_chapter(foreign)
+    with pytest.raises(ValueError, match="Select"):
+        o.delete_chapters(sid, [foreign])
+    with pytest.raises(ValueError, match="at least one chapter"):
+        o.delete_chapters(sid, [ids[0], ids[2]])
+    assert len(store.list_chapters(sid)) == 2
+
+
 @pytest.mark.parametrize(
     "mode,chapters,fields,message",
     [