Simplify the upload state and the story page data

The pause of the user and a missing ingest folder are separate checks.
One function gives the upload state to the settings and the story page.
A route that returns only a story no longer loads its chapters or asks
CWA for its book. The story page data loses the values that no page reads.

tests/js/flows.test.mjs

@@ -647,7 +647,7 @@ test('with CWA off, the pages show nothing about CWA', async () => {
   assert.ok(section(main, 'Library link'));
   const off = { ...config, cwa_enabled: false, library_available: false };
   // Values that show a notice with CWA on.
-  Object.assign(details, { uploads_paused: true, ingest_available: false, link_books: false });
+  Object.assign(details, { pause_uploads: true, ingest_available: false, link_books: false });
   details.story.upload_held = true;
   await mountStory(off);
   assert.ok(section(main, 'Metadata'));

tests/js/upload-hold.test.mjs

@@ -15,7 +15,7 @@ const details = (story, extra = {}) => ({
     calibre_id: null, calibre_uuid: null, ingested_at: null, upload_held: false, needs_approval: false, ...story },
   chapters: [],
   recent_chapters: 0,
-  uploads_paused: false,
+  pause_uploads: false,
   book: null,
   ...extra,
 });
@@ -192,7 +192,7 @@ for (const uuid of [null, 'book-7']) {
   test(`approval while paused saves the decision without promising an upload: ${uuid}`, async (t) => {
     const data = details(
       { calibre_id: uuid ? 7 : null, calibre_uuid: uuid, upload_held: true, needs_approval: true },
-      { link_books: true, uploads_paused: true },
+      { link_books: true, pause_uploads: true },
     );
     const { backend, notice } = await renderStory(t, data);
     assert.ok(find(notice, 'button', 'Approve'));
@@ -208,7 +208,7 @@ for (const uuid of [null, 'book-7']) {
 test('approval as a new book while paused keeps the pause in the confirmation', async (t) => {
   const data = details(
     { calibre_id: 7, calibre_uuid: 'book-7', upload_held: true, needs_approval: true },
-    { link_books: true, uploads_paused: true },
+    { link_books: true, pause_uploads: true },
   );
   const { backend, notice } = await renderStory(t, data);
   const confirm = t.mock.method(window, 'confirm', () => true);
@@ -239,7 +239,7 @@ test('a new story asks for approval to go to CWA as a new book', async (t) => {
 test('a paused upload points to the settings', async (t) => {
   const { notice } = await renderStory(
     t,
-    details({ calibre_id: 7, calibre_uuid: 'book-7', ingested_at: '2026-01-01', upload_held: true }, { book, uploads_paused: true }),
+    details({ calibre_id: 7, calibre_uuid: 'book-7', ingested_at: '2026-01-01', upload_held: true }, { book, pause_uploads: true }),
   );
   assert.match(notice.textContent, /Uploads to CWA are paused/);
   assert.equal(find(notice, 'a', 'Settings').attributes.href, '#/settings');
@@ -253,7 +253,7 @@ for (const savedId of [null, 7]) {
         const { notice } = await renderStory(t, details(
           { calibre_id: savedId, calibre_uuid: savedId ? 'book-7' : null,
             upload_held: true, needs_approval: needsApproval },
-          { link_books: false, uploads_paused: paused },
+          { link_books: false, pause_uploads: paused },
         ));
         if (savedId !== null && !paused) {
           assert.equal(notice, undefined);
@@ -294,7 +294,7 @@ test('a story that went to CWA without a link shows no approval until Bindery fi
 
 test('missing INGEST_DIR points to the environment rather than the disabled pause switch', async (t) => {
   const { notice } = await renderStory(t, details(
-    { upload_held: true }, { uploads_paused: true, ingest_available: false },
+    { upload_held: true }, { pause_uploads: true, ingest_available: false },
   ));
   assert.equal(notice.textContent, 'Set INGEST_DIR and restart Bindery to enable uploads.');
   assert.equal(nodes(notice).filter((el) => el.tagName === 'button').length, 0);
@@ -303,7 +303,7 @@ test('missing INGEST_DIR points to the environment rather than the disabled paus
 test('missing library sources leave uploads enabled with the duplicate warning', async (t) => {
   const { notice } = await renderStory(t, details(
     { ingested_at: '2026-01-01', upload_held: true, needs_approval: true },
-    { link_books: false, library_matching_available: false },
+    { link_books: false },
   ));
   assert.match(notice.textContent, /If CWA imports them, updates will create duplicate books/);
   assert.equal(nodes(notice).filter((el) => el.tagName === 'button').length, 0);
@@ -312,7 +312,7 @@ test('missing library sources leave uploads enabled with the duplicate warning',
 test('a new book asks for approval when library linking is enabled', async (t) => {
   const { notice } = await renderStory(t, details(
     { upload_held: true, needs_approval: true },
-    { link_books: true, library_matching_available: true },
+    { link_books: true },
   ));
   assert.match(notice.textContent, /^Approve this story as a new CWA book\./);
   assert.ok(find(notice, 'button', 'Approve and send'));
@@ -320,7 +320,7 @@ test('a new book asks for approval when library linking is enabled', async (t) =
 
 test('approval before a build still shows the pause and never offers to send', async (t) => {
   const { notice } = await renderStory(t, details(
-    { needs_approval: true }, { uploads_paused: true },
+    { needs_approval: true }, { pause_uploads: true },
   ));
   assert.match(notice.textContent, /Uploads to CWA are paused\. Resume them in Settings\./);
   assert.ok(find(notice, 'button', 'Approve'));

tests/test_api_flows.py

@@ -187,3 +187,15 @@ def test_chapter_requests_without_ids_name_what_to_select(client, story):
     for body in ({}, {"chapter_ids": None}):
         response = client.post(f"/api/stories/{sid}/chapters/delete", json=body, headers=H)
         assert (response.status_code, response.json["error"]) == (400, "Select the chapters to delete")
+
+
+def test_a_story_change_does_not_ask_cwa_for_the_book(client, story, monkeypatch):
+    sid, _ = story
+    o.store.update_story(sid, calibre_id=7, calibre_uuid="book-7")
+    monkeypatch.setattr(config, "CWA_URL", "https://cwa.example")
+    cwa = Mock()
+    monkeypatch.setattr(o, "cwa", lambda: cwa)
+    response = client.put(f"/api/stories/{sid}/settings", json={"recheck_days": 4}, headers=H)
+    assert response.json["recheck_days"] == 4
+    assert "chapters" not in response.json
+    cwa.get_book.assert_not_called()

tests/test_optional_cwa.py

@@ -218,7 +218,7 @@ def test_build_without_ingest_succeeds_and_keeps_the_book_local(monkeypatch, tmp
     assert list(config.TMP_DIR.glob(f"story-{story_id}-*.epub"))
     assert not list((tmp_path / "ingest").iterdir())
     details = orchestrator.story_details(story_id)
-    assert details["uploads_paused"] is True
+    assert details["pause_uploads"] is True
     assert details["story"]["upload_held"] is True
     assert details["library_error"] is None
 
@@ -454,12 +454,11 @@ def test_missing_library_connection_is_not_an_approval_hold(client, monkeypatch)
     assert details["story"]["upload_held"] is False
     assert details["story"]["needs_approval"] is False
     assert details["link_books"] is False
-    assert details["library_matching_available"] is False
     assert details["ingest_available"] is True
     monkeypatch.setattr(config, "INGEST_DIR", None)
     assert client.get(f"/api/stories/{story_id}").json["ingest_available"] is False
     monkeypatch.setattr(config, "CWA_URL", "https://cwa.invalid")
-    assert client.get(f"/api/stories/{story_id}").json["library_matching_available"] is True
+    assert client.get(f"/api/stories/{story_id}").json["link_books"] is True
 
 
 @pytest.mark.parametrize("missing_ingest", [False, True])